[PATCH obexd] Obexd: Add parse apparam support to Obex Put

Subsystems: the rest

STALE5330d

3 messages, 2 authors, 2012-02-20 · open the first message on its own page

[PATCH obexd] Obexd: Add parse apparam support to Obex Put

From: Divya Yadav <hidden>
Date: 2012-02-20 13:16:54

Add parse apparam support to Obex put, which is missing in
current code.
---
 src/obex.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/obex.c b/src/obex.c
index 5b580d3..f9b7e22 100644
--- a/src/obex.c
+++ b/src/obex.c
@@ -978,6 +978,7 @@ static void cmd_put(GObex *obex, GObexPacket *req, gpointer user_data)
 	parse_name(os, req);
 	parse_length(os, req);
 	parse_time(os, req);
+	parse_apparam(os, req);
 
 	if (!os->checked) {
 		if (!check_put(obex, req, user_data))
-- 
1.7.0.4

Re: [PATCH obexd] Obexd: Add parse apparam support to Obex Put

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-02-20 13:39:55

Hi Divya,

On Mon, Feb 20, 2012 at 3:16 PM, Divya Yadav [off-list ref] wrote:
quoted hunk
Add parse apparam support to Obex put, which is missing in
current code.
---
 src/obex.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/obex.c b/src/obex.c
index 5b580d3..f9b7e22 100644
--- a/src/obex.c
+++ b/src/obex.c
@@ -978,6 +978,7 @@ static void cmd_put(GObex *obex, GObexPacket *req, gpointer user_data)
       parse_name(os, req);
       parse_length(os, req);
       parse_time(os, req);
+       parse_apparam(os, req);

       if (!os->checked) {
               if (!check_put(obex, req, user_data))
--
1.7.0.4
Please use "core:" prefix when the patch changes code in src/, btw if
there are plugins depending on this than it is a real fix and you
should start with "core: Fix..." otherwise Im fine with the patch even
if nobody uses apparam for PUT.

-- 
Luiz Augusto von Dentz

Re: [PATCH obexd] Obexd: Add parse apparam support to Obex Put

From: Divya Yadav <hidden>
Date: 2012-02-20 13:52:27

Hello Luiz,

--------------------------------------------------
From: "Luiz Augusto von Dentz" <luiz.dentz@gmail.com>
Sent: Monday, February 20, 2012 7:09 PM
To: "Divya Yadav" <redacted>
Cc: <redacted>
Subject: Re: [PATCH obexd] Obexd: Add parse apparam support to Obex Put
Hi Divya,

On Mon, Feb 20, 2012 at 3:16 PM, Divya Yadav [off-list ref] 
wrote:
quoted
Add parse apparam support to Obex put, which is missing in
current code.
---
 src/obex.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/obex.c b/src/obex.c
index 5b580d3..f9b7e22 100644
--- a/src/obex.c
+++ b/src/obex.c
@@ -978,6 +978,7 @@ static void cmd_put(GObex *obex, GObexPacket *req, 
gpointer user_data)
       parse_name(os, req);
       parse_length(os, req);
       parse_time(os, req);
+       parse_apparam(os, req);

       if (!os->checked) {
               if (!check_put(obex, req, user_data))
--
1.7.0.4
Please use "core:" prefix when the patch changes code in src/, btw if
there are plugins depending on this than it is a real fix and you
should start with "core: Fix..." otherwise Im fine with the patch even
if nobody uses apparam for PUT.
We will use apparam for PUT in MAP Profile. In MAP we use it for 
MessageStatusUpdate
and UpdateInbox features. I will send the fix again with "core:" prefix 
changes.
-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" 
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help