Re: [PATCH 1/1] rust: block: Fix unsoundness in `Operations::queue_rq`

On Mon, Sep 14, 2026 at 10:47 PM Priya Bala Govindasamy
[off-list ref] wrote:

Fixes: 3253aba3408a ("rust: block: introduce `kernel::block::mq` module")

Should this have Cc: stable?

Assisted-by: ChatGPT:gpt-5.6-sol

Nowadays, it is enough to say "Assisted-by: LLM" (the rules recently changed).

Signed-off-by: Priya Bala Govindasamy<redacted>

The tags seem to be missing a space before `<`.

Cc'ing the linux-block list too (please see the `MAINTAINERS` file).

Finally, it is usually nice to provide a simple example when possible
of the safe code that triggers the issue.

+    /// # Safety
+    ///
+    /// The implementor of this method must ensure that if Err is returned:
+    /// - The request has not already been completed.
+    /// - No ARef derived from the request remains anywhere.
+    /// - No reference was converted to raw or transferred to another thread.
+    unsafe fn queue_rq(

The `# Safety` section is about the preconditions for callers, not for
implementers of the trait -- this should likely be on the trait.
Should this method be `unsafe fn` then? Did you build with `CLIPPY=1`?

Also, please add intra-doc links where possible, and please see
Sashiko's output too.

Thanks!

Cheers,
Miguel