Re: [PATCH v2 4/9] blk-mq-debugfs: warn about possible deadlock
From: kernel test robot <hidden>
Date: 2025-11-21 23:32:59
Also in:
oe-kbuild-all
Hi Yu, kernel test robot noticed the following build errors: [auto build test ERROR on axboe/for-next] [also build test ERROR on linus/master v6.18-rc6 next-20251121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/blk-mq-debugfs-factor-out-a-helper-to-register-debugfs-for-all-rq_qos/20251121-143315 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git for-next patch link: https://lore.kernel.org/r/20251121062829.1433332-5-yukuai%40fnnas.com patch subject: [PATCH v2 4/9] blk-mq-debugfs: warn about possible deadlock config: parisc-randconfig-002-20251122 (https://download.01.org/0day-ci/archive/20251122/202511220719.yaFySU2X-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 14.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251122/202511220719.yaFySU2X-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202511220719.yaFySU2X-lkp@intel.com/ (local) All errors (new ones prefixed by >>): In file included from include/linux/bug.h:5, from include/linux/vfsdebug.h:5, from include/linux/fs.h:5, from include/linux/highmem.h:5, from include/linux/bvec.h:10, from include/linux/blk_types.h:10, from include/linux/blkdev.h:9, from block/blk-mq-debugfs.c:7: block/blk-mq-debugfs.c: In function 'debugfs_create_files':
quoted
block/blk-mq-debugfs.c:628:35: error: 'struct request_queue' has no member named 'blkcg_mutex'
628 | lockdep_assert_not_held(&q->blkcg_mutex);
| ^~
arch/parisc/include/asm/bug.h:86:32: note: in definition of macro 'WARN_ON'
86 | int __ret_warn_on = !!(x); \
| ^
include/linux/lockdep.h:288:9: note: in expansion of macro 'lockdep_assert'
288 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_HELD)
| ^~~~~~~~~~~~~~
include/linux/lockdep.h:288:24: note: in expansion of macro 'lockdep_is_held'
288 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_HELD)
| ^~~~~~~~~~~~~~~
block/blk-mq-debugfs.c:628:9: note: in expansion of macro 'lockdep_assert_not_held'
628 | lockdep_assert_not_held(&q->blkcg_mutex);
| ^~~~~~~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for OF_GPIO
Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
Selected by [y]:
- GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
WARNING: unmet direct dependencies detected for GPIO_SYSCON
Depends on [n]: GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF [=n]
Selected by [y]:
- GPIO_SAMA5D2_PIOBU [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF_GPIO [=y] && (ARCH_AT91 || COMPILE_TEST [=y])
WARNING: unmet direct dependencies detected for I2C_K1
Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && OF [=n]
Selected by [y]:
- MFD_SPACEMIT_P1 [=y] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && I2C [=y]
vim +628 block/blk-mq-debugfs.c
612
613 static void debugfs_create_files(struct request_queue *q, struct dentry *parent,
614 void *data,
615 const struct blk_mq_debugfs_attr *attr)
616 {
617 /*
618 * Creating new debugfs entries with queue freezed has the risk of
619 * deadlock.
620 */
621 WARN_ON_ONCE(q->mq_freeze_depth != 0);
622 /*
623 * debugfs_mutex should not be nested under other locks that can be
624 * grabbed while queue is frozen.
625 */
626 lockdep_assert_not_held(&q->elevator_lock);
627 lockdep_assert_not_held(&q->rq_qos_mutex);
> 628 lockdep_assert_not_held(&q->blkcg_mutex);
629
630 if (IS_ERR_OR_NULL(parent))
631 return;
632
633 for (; attr->name; attr++)
634 debugfs_create_file_aux(attr->name, attr->mode, parent,
635 (void *)attr, data, &blk_mq_debugfs_fops);
636 }
637
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki