Re: [PATCH 1/3] block/genhd: add sysfs knobs for the device frequency PM QoS
From: Bart Van Assche <bvanassche@acm.org>
Date: 2025-09-15 21:15:41
Also in:
linux-pm, linux-scsi, lkml
On 9/14/25 4:45 AM, Wang Jianzheng wrote:
block/genhd.c | 23 +++++++++++++++++++++++ include/linux/blkdev.h | 2 ++
If a new sysfs attribute is added then an entry must be added in Documentation/ABI/ that explains the purpose of the new attribute and also how to use it.
quoted hunk ↗ jump to hunk
--- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h@@ -213,6 +213,8 @@ struct gendisk { u64 diskseq; blk_mode_t open_mode; + int dev_freq_timeout;
The name `dev_freq_timeout` is not sufficient to guess the meaning of the attribute. Please add a comment. Thanks, Bart.