Thread (3 messages) 3 messages, 3 authors, 2025-08-26

Re: [PATCH] block: rename min_segment_size

From: Keith Busch <kbusch@kernel.org>
Date: 2025-08-25 19:50:13

On Mon, Aug 25, 2025 at 03:18:43PM -0400, Martin K. Petersen wrote:
Christoph,
quoted
But max_aligned_segment also feels wrong for that. It's not really the
maximum alignmnet, it is the fast path alignment. Maybe something like
fast_segment_granularity or nosplit_segment_granularity?
Maybe just segment_granularity to match the other granularities we have?
I'm not sure I like granularity for this limit. That sounds like it
defines segments to be sized to some multiple of that value, but it's
perfectly fine to use smaller segments.

The limit defines the largest aligned segment the block layer can know
for certain won't need to be split. This allows a short cut while
counting segments without checking against any other limits.

  max_aligned_unsplittable_segment_size

That's pretty verbose, but this limit is kind of unique in its purpose.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help