Thread (4 messages) 4 messages, 3 authors, 2025-08-25

Re: [PATCH] block: Move a misplaced comment in queue_wb_lat_store()

From: Bart Van Assche <bvanassche@acm.org>
Date: 2025-08-25 15:08:59

On 8/25/25 6:48 AM, Jens Axboe wrote:
On Fri, Aug 22, 2025 at 2:02?PM Bart Van Assche [off-list ref] wrote:
quoted
blk_mq_quiesce_queue() does not wait for pending I/O to finish. Freezing
a queue waits for pending I/O to finish. Hence move the comment that
refers to waiting for pending I/O above the call that freezes the
request queue. This patch moves this comment back to the position where
it was when this comment was introduced. See also commit c125311d96b1
("blk-wbt: don't maintain inflight counts if disabled").
Doesn't apply to the current tree, what is this against?
These patches are in my local tree and are causing the failure to apply:
"[PATCH 0/3] Fix a deadlock related to modifying queue attributes"
(https://lore.kernel.org/linux-block/20250702182430.3764163-1-bvanassche@acm.org/ (local)). 
I should have removed these from my local tree
before I posted this patch.
In any case, please resend.
Sure, I will do that.

Thanks,

Bart.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help