On Tue, Aug 05, 2025 at 04:32:22PM -0400, Caleb Sander Mateos wrote:

On Tue, Aug 5, 2025 at 3:59 PM Keith Busch [off-list ref] wrote:

quoted

+#define bv_seg_gap(bv, bvprv) \
+       bv.bv_offset | ((bvprv.bv_offset + bvprv.bv_len) & (PAGE_SIZE - 1));

Extra semicolon and missing parentheses around inputs and output. Is
there a reason not to make this a static inline function rather than a
macro?

Using onstack bio_vec's made sense to manipulate with macros rather than
functions. But I suppose a static inline function won't push copies on
the stack either, so sure, I can change it.