Re: [PATCH 1/2] fs: add a FMODE_ flag to indicate IOCB_HAS_METADATA availability
From: Christoph Hellwig <hch@lst.de>
Date: 2025-08-25 13:35:23
Also in:
io-uring, linux-fsdevel
From: Christoph Hellwig <hch@lst.de>
Date: 2025-08-25 13:35:23
Also in:
io-uring, linux-fsdevel
On Mon, Aug 25, 2025 at 02:01:07PM +0200, Christian Brauner wrote:
On Thu, Aug 21, 2025 at 10:42:13AM +0200, Christoph Hellwig wrote:quoted
On Wed, Aug 20, 2025 at 11:40:36AM +0200, Christian Brauner wrote:quoted
I meant something like this which should effectively be the same thing just that we move the burden of having to use two bits completely into file->f_iocb_flags instead of wasting a file->f_mode bit:Yeah, that could work. But I think the double use of f_iocb_flags is a bit confusing. Another option at least for this case would be to have a FOP_ flag, and then check inside the operation if it is supported for this particular instance.Do you want to try something like that? Maybe we can do this for other FMODE_*-based IOCB_* opt{in,outs}?
Yes, I also need to move on of the FOP_ flags to a scheme like that. However I'm pretty busy at the momen, so I'm unlikely to get to it before mid-September.