Thread (1 message) 1 message, 1 author, 2025-08-20

Re: [PATCH 2/2] block: don't silently ignore metadata for sync read/write

From: Martin K. Petersen <hidden>
Date: 2025-08-20 03:23:24
Also in: io-uring, linux-fsdevel

Christoph,
The block fops don't try to handle metadata for synchronous requests,
probably because the completion handler looks at dio->iocb which is
not valid for synchronous requests.

But silently ignoring metadata (or warning in case of
__blkdev_direct_IO_simple) is a really bad idea as that can cause
silent data corruption if a user ever shows up.
Looks fine.

Reviewed-by: Martin K. Petersen <redacted>

-- 
Martin K. Petersen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help