[PATCH blktests v2 1/3] scsi/010: add unmap write zeroes tests
From: Zhang Yi <hidden>
Date: 2025-08-13 02:52:15
Also in:
dm-devel, linux-fsdevel, linux-nvme, linux-scsi, lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Zhang Yi <yi.zhang@huawei.com> Test block device unmap write zeroes sysfs interface with various SCSI debug devices. /sys/block/<disk>/queue/write_zeroes_unmap_max_hw_bytes should equal to the write_zeroes_max_bytes if the SCSI device enable the WRITE SAME command with unmap functionality, and it should return 0 otherwise. /sys/block/<disk>/queue/write_zeroes_unmap_max_bytes should be equal to write_zeroes_unmap_max_hw_bytes by default, and we can disable write zeroes support by setting it to zero. Signed-off-by: Zhang Yi <yi.zhang@huawei.com> --- tests/scsi/010 | 84 ++++++++++++++++++++++++++++++++++++++++++++++ tests/scsi/010.out | 2 ++ 2 files changed, 86 insertions(+) create mode 100755 tests/scsi/010 create mode 100644 tests/scsi/010.out
diff --git a/tests/scsi/010 b/tests/scsi/010
new file mode 100755
index 0000000..c5152a4
--- /dev/null
+++ b/tests/scsi/010@@ -0,0 +1,84 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-3.0+ +# Copyright (C) 2025 Huawei. +# +# Test block device unmap write zeroes sysfs interface with various scsi +# devices. + +. tests/scsi/rc +. common/scsi_debug + +DESCRIPTION="test unmap write zeroes sysfs interface with scsi devices" +QUICK=1 + +requires() { + _have_scsi_debug +} + +setup_test_device() { + if ! _configure_scsi_debug "$@"; then + return 1 + fi + + if [[ ! -f /sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_hw_bytes ]]; then + _exit_scsi_debug + SKIP_REASONS+=("kernel does not support unmap write zeroes sysfs interface") + return 1 + fi +} + +test() { + echo "Running ${TEST_NAME}" + + # disable WRITE SAME with unmap + if ! setup_test_device lbprz=0; then + return 1 + fi + + umap_hw_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_hw_bytes")" + umap_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_bytes")" + if [[ $umap_hw_bytes -ne 0 || $umap_bytes -ne 0 ]]; then + echo "Test disable WRITE SAME with unmap failed." + fi + _exit_scsi_debug + + # enable WRITE SAME(16) with unmap + if ! setup_test_device lbprz=1 lbpws=1; then + return 1 + fi + + zero_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_max_bytes")" + umap_hw_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_hw_bytes")" + umap_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_bytes")" + if [[ $umap_hw_bytes -ne $zero_bytes || $umap_bytes -ne $zero_bytes ]]; then + echo "Test enable WRITE SAME(16) with unmap failed." + fi + + echo 0 > "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_bytes" + umap_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_bytes")" + if [[ $umap_bytes -ne 0 ]]; then + echo "Test manually disable WRITE SAME(16) with unmap failed." + fi + _exit_scsi_debug + + # enable WRITE SAME(10) with unmap + if ! setup_test_device lbprz=1 lbpws10=1; then + return 1 + fi + + zero_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_max_bytes")" + umap_hw_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_hw_bytes")" + umap_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_bytes")" + if [[ $umap_hw_bytes -ne $zero_bytes || $umap_bytes -ne $zero_bytes ]]; then + echo "Test enable WRITE SAME(10) with unmap failed." + fi + + echo 0 > "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_bytes" + umap_bytes="$(cat "/sys/block/${SCSI_DEBUG_DEVICES[0]}/queue/write_zeroes_unmap_max_bytes")" + if [[ $umap_bytes -ne 0 ]]; then + echo "Test manually disable WRITE SAME(10) with unmap failed." + fi + _exit_scsi_debug + + echo "Test complete" +}
diff --git a/tests/scsi/010.out b/tests/scsi/010.out
new file mode 100644
index 0000000..6581d5e
--- /dev/null
+++ b/tests/scsi/010.out@@ -0,0 +1,2 @@ +Running scsi/010 +Test complete
--
2.39.2