Thread (3 messages) 3 messages, 3 authors, 2025-09-01

Re: [PATCH v3] block: mtip32xx: Remove excess code in mtip_pci_probe

From: Philipp Stanner <hidden>
Date: 2025-08-27 13:50:24
Also in: lkml

On Wed, 2025-08-27 at 21:12 +0800, Zhang Heng wrote:
In the error exit function of the iomap_err in mtip_pci_probe,
pci_set_drvdata(pdev, NULL) and return can be removed without
affecting the code execution

Signed-off-by: Zhang Heng <redacted>
Reviewed-by: Philipp Stanner <phasta@kernel.org>
quoted hunk ↗ jump to hunk
---
 drivers/block/mtip32xx/mtip32xx.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 8fc7761397bd..2c33c1dfc39d 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3840,8 +3840,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,
 
 iomap_err:
 	kfree(dd);
-	pci_set_drvdata(pdev, NULL);
-	return rv;
 done:
 	return rv;
 }
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help