Thread (16 messages) 16 messages, 3 authors, 2025-07-31

Re: [PATCHv3 2/7] blk-mq-dma: provide the bio_vec list being iterated

From: Keith Busch <kbusch@kernel.org>
Date: 2025-07-29 20:55:14
Also in: linux-nvme

On Tue, Jul 29, 2025 at 07:34:37AM -0700, Keith Busch wrote:
quoted hunk ↗ jump to hunk
@@ -244,8 +244,10 @@ int __blk_rq_map_sg(struct request *rq, struct scatterlist *sglist,
 	int nsegs = 0;
 
 	/* the internal flush request may not have bio attached */
-	if (bio)
+	if (bio) {
 		iter.iter = bio->bi_iter;
+		iter.bvec = bio->bi_io_vec;
Oops, this should have been:

		if (rq->rq_flags & RQF_SPECIAL_PAYLOAD)
			iter.bvec = &rq->special_vec;
		else
			iter.bvec = bio->bi_io_vec;

Hopefully over time everything coverts to the dma iterator and this
legacy sg mapping can fade away.
+	}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help