Re: [PATCH 2/3] blk-wbt: Eliminate ambiguity in the comments of struct rq_wb
From: Yu Kuai <yukuai@kernel.org>
Date: 2025-07-25 18:13:44
Also in:
lkml
From: Yu Kuai <yukuai@kernel.org>
Date: 2025-07-25 18:13:44
Also in:
lkml
Hi, 在 2025/7/24 16:30, Tang Yizhou 写道:
From: Tang Yizhou <redacted> In the current implementation, the last_issue and last_comp members of struct rq_wb are used only by read requests and not by non-throttled write requests. Therefore, eliminate the ambiguity here. Signed-off-by: Tang Yizhou <redacted> --- block/blk-wbt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/block/blk-wbt.c b/block/blk-wbt.c index 30886d44f6cd..eb8037bae0bd 100644 --- a/block/blk-wbt.c +++ b/block/blk-wbt.c@@ -85,8 +85,8 @@ struct rq_wb { u64 sync_issue; void *sync_cookie; - unsigned long last_issue; /* last non-throttled issue */ - unsigned long last_comp; /* last non-throttled comp */ + unsigned long last_issue; /* issue time of last read rq */ + unsigned long last_comp; /* completion time of last read rq */ unsigned long min_lat_nsec; struct rq_qos rqos; struct rq_wait rq_wait[WBT_NUM_RWQ];
Not sure if this is worth it, I'm more concerned about backport trouble. Thanks, Kuai