Re: [PATCH] block: cleanup and fix batch completion adding conditions

On 2/28/25 4:59 AM, Ondrej Kozina wrote:

Hi Jens,

this patch introduced regression to locked SED OPAL2 devices. The locked region no longer returns -EIO upon IO. On read the caller receives block of zeroes, on write it does not report any error either. In both cases, previous to this patch, the caller would get IO error (expected) with locked device.

It was discovered by cryptsetup testsuite specifically https://gitlab.com/cryptsetup/cryptsetup/-/blob/main/tests/compat-test-opal

I've attached a simple patch that changes the ioerror condition and it fixed the problem with SED OPAL2 devices for me.

#regzbot introduced: 1f47ed294a2bd577d5ae43e6e28e1c9a3be4a833

Oops thanks - does someone want to send a "real" patch with commit message
etc, or do you just want me to queue something up?

-- 
Jens Axboe