Thread (21 messages) 21 messages, 3 authors, 2025-02-25

Re: [PATCHv3 4/7] block: Introduce a dedicated lock for protecting queue elevator updates

From: Christoph Hellwig <hch@lst.de>
Date: 2025-02-24 16:34:03

There's weird upper case for the first character after block.  I know
some subsystems like this, but in general try to at least be consistent
for the series.
+	/*
+	 * attributes which require some form of locking
+	 * other than q->sysfs_lock
Make that a proper sentence:

	 * Attributes which require some form of locking
	 * other than q->sysfs_lock.
+	/*
+	 * protects elevator switch/update
+	 */
Also make this a full sentence, and mention which fields this protects.

Otherwise looks good.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help