Re: [PATCH 7/7] xfs: implement block-metadata based data checksums

On Tue, Feb 04, 2025 at 10:36:51AM -0800, Darrick J. Wong wrote:

quoted

quoted

The crc32c generation and validation looks decent though we're
definitely going to want an inode flag so that we're not stuck with
stable page writes.

Yeah, support the NOCOW flag, have a sb flag to enable the checksums,
maybe even a field about what checksum to use, yodda, yodda.

Why do we need nocow?  Won't the block contents and the PI data get
written in an untorn fashion?

I mean to say NODATASUM, not NOCOW.  Sorry for the confusion that
this caused.