Thread (4 messages) 4 messages, 4 authors, 2025-02-26

Re: [PATCH] ublk: complete command synchronously on error

From: Jens Axboe <axboe@kernel.dk>
Date: 2025-02-26 14:32:06
Also in: io-uring, lkml

On Tue, 25 Feb 2025 14:24:55 -0700, Caleb Sander Mateos wrote:
In case of an error, ublk's ->uring_cmd() functions currently return
-EIOCBQUEUED and immediately call io_uring_cmd_done(). -EIOCBQUEUED and
io_uring_cmd_done() are intended for asynchronous completions. For
synchronous completions, the ->uring_cmd() function can just return the
negative return code directly. This skips io_uring_cmd_del_cancelable(),
and deferring the completion to task work. So return the error code
directly from __ublk_ch_uring_cmd() and ublk_ctrl_uring_cmd().

[...]
Applied, thanks!

[1/1] ublk: complete command synchronously on error
      commit: 6376ef2b6af3bbcb7c50dc657bdfb83aba467aef

Best regards,
-- 
Jens Axboe


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help