On Thu, Jan 16, 2025, at 22:18, Jason Gunthorpe wrote:

On Wed, Jan 15, 2025 at 10:33:40AM +0200, Leon Romanovsky wrote:

quoted

quoted

quoted

+	do {
+		phys_addr_t phys;
+		size_t len;
+
+		phys = iommu_iova_to_phys(domain, addr);
+		if (WARN_ON(!phys))
+			continue;

Infinite WARN_ON loop, nice.

No problem, will change it to WARN_ON_ONCE.

I think the other point is that the addr doesn't increase, so this
loop will lock up.

Yes, this is what I planned to do.

Possibly just do return? I suppose something is hopelessly corrupted
if we ever hit this..

Jason