Re: [PATCH v3 2/3] rust: uaccess: simplify Result<()> in bytes_add_one return
From: Boqun Feng <hidden>
Date: 2024-11-18 20:10:14
Also in:
lkml, netdev, rust-for-linux
Hi Manas, On Mon, Nov 18, 2024 at 08:06:59PM +0530, Manas via B4 Relay wrote:
From: Manas <redacted> bytes_add_one returns `Result<()>`, a result over unit type. This can be
This is a bit nitpicking from my side, but usually when referring to the name of a function, I would suggest adding the parentheses, i.e. "bytes_add_one()". In this way, it's more clear that it's a function (instead of a variable or something else).
simplified to `Result` as default type parameters are unit `()` and `Error` types. Thus keep the usage of `Result` consistent throughout codebase. Suggested-by: Miguel Ojeda <ojeda@kernel.org> Link: https://github.com/Rust-for-Linux/linux/issues/1128 Signed-off-by: Manas <redacted>
Reviewed-by: Boqun Feng <redacted> Regards, Boqun
quoted hunk ↗ jump to hunk
--- rust/kernel/uaccess.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/rust/kernel/uaccess.rs b/rust/kernel/uaccess.rs index 05b0b8d13b10da731af62be03e1c2c13ced3f706..7c21304344ccd943816e38119a5be2ccf8d8e154 100644 --- a/rust/kernel/uaccess.rs +++ b/rust/kernel/uaccess.rs@@ -49,7 +49,7 @@ /// use kernel::error::Result; /// use kernel::uaccess::{UserPtr, UserSlice}; /// -/// fn bytes_add_one(uptr: UserPtr, len: usize) -> Result<()> { +/// fn bytes_add_one(uptr: UserPtr, len: usize) -> Result { /// let (read, mut write) = UserSlice::new(uptr, len).reader_writer(); /// /// let mut buf = KVec::new();-- 2.47.0