Thread (15 messages) 15 messages, 4 authors, 2024-09-16

Re: [PATCHv5 4/9] blk-integrity: consider entire bio list for merging

From: Christoph Hellwig <hch@lst.de>
Date: 2024-09-14 07:30:16
Also in: linux-nvme, linux-scsi

On Fri, Sep 13, 2024 at 11:28:49AM -0700, Keith Busch wrote:
From: Keith Busch <kbusch@kernel.org>

If a bio is merged to a request, the entire bio list is merged, so don't
temporarily detach it from its list when counting segments. In most
cases, bi_next will already be NULL, so detaching is usually a no-op.
But if the bio does have a list, the current code is miscounting the
segments for the resulting merge.
As I explained in detail last round this is still wrong.  There is
no bio list here ever.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help