Re: [PATCH v6 2/3] block, fs: restore kiocb based write hint processing
From: Hannes Reinecke <hare@suse.de>
Date: 2024-09-25 05:49:43
Also in:
io-uring, linux-fsdevel, linux-nvme
From: Hannes Reinecke <hare@suse.de>
Date: 2024-09-25 05:49:43
Also in:
io-uring, linux-fsdevel, linux-nvme
On 9/24/24 11:24, Kanchan Joshi wrote:
struct kiocb has a 2 bytes hole that developed post commit 41d36a9f3e53
("fs: remove kiocb.ki_hint").
But write hint has made a comeback with commit 449813515d3e ("block, fs:
Restore the per-bio/request data lifetime fields").
This patch uses the leftover space in kiocb to carve 1 byte field
ki_write_hint.
Restore the code that operates on kiocb to use ki_write_hint instead of
inode hint value.
This does not bring any behavior change, but needed to enable per-io
hints (by another patch).
Signed-off-by: Kanchan Joshi <redacted>
Signed-off-by: Nitesh Shetty <redacted>
---
block/fops.c | 6 +++---
fs/aio.c | 1 +
fs/cachefiles/io.c | 1 +
fs/direct-io.c | 2 +-
fs/iomap/direct-io.c | 2 +-
include/linux/fs.h | 8 ++++++++
io_uring/rw.c | 1 +
7 files changed, 16 insertions(+), 5 deletions(-)Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich