Thread (7 messages) 7 messages, 5 authors, 2024-06-24

Re: [PATCHv4 blktests] nvme: add test for creating/deleting file-ns

From: Venkat Rao Bagalkote <hidden>
Date: 2024-06-20 08:28:45
Also in: linux-nvme

Tested this patch, with and without the below fix, and observing 
expected results.

https://lore.kernel.org/all/20240613164246.75205-1-kbusch@meta.com/ (local)

Tested-by: Venkat Rao Bagalkote <redacted>

Regards,
Venkat.
On 20/06/24 12:10 pm, Nilay Shroff wrote:
On 6/20/24 12:05, Daniel Wagner wrote:
quoted
On Wed, Jun 19, 2024 at 10:55:02PM GMT, Nilay Shroff wrote:
quoted
+		truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
+		uuid="$(uuidgen -r)"
This adds a new dependency on an external tool. It should be mentioned
in the README and added to the list of tools to check for:
_check_dependencies(). Alternatively you could skip the test if the tool
is not available. Anyway the rest looks good.
The "uuidgen" is part of util-linux package and I saw that it's already mentioned
as one of the required packages for blktest: https://github.com/osandov/blktests
quoted
Reviewed-by: Daniel Wagner <redacted>
Thanks,
--Nilay
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help