Re: [PATCH 04/12] sd: add a sd_disable_discard helper

convert the SCSI ULDs to the atomic queue limits API · Christoph Hellwig <hch@lst.de> · 2024-05-29
[PATCH 01/12] ubd: untagle discard vs write zeroes not support handling · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 01/12] ubd: untagle discard vs write zeroes not support handling · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 01/12] ubd: untagle discard vs write zeroes not support handling · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
[PATCH 02/12] block: take io_opt and io_min into account for max_sectors · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors · Ilya Dryomov <idryomov@gmail.com> · 2024-05-30
Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors · Christoph Hellwig <hch@lst.de> · 2024-05-31
Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors · Ilya Dryomov <idryomov@gmail.com> · 2024-05-31
Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors · Christoph Hellwig <hch@lst.de> · 2024-05-31
[PATCH 03/12] sd: simplify the ZBC case in provisioning_mode_store · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 03/12] sd: simplify the ZBC case in provisioning_mode_store · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 03/12] sd: simplify the ZBC case in provisioning_mode_store · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
[PATCH 04/12] sd: add a sd_disable_discard helper · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 04/12] sd: add a sd_disable_discard helper · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 04/12] sd: add a sd_disable_discard helper · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
[PATCH 05/12] sd: add a sd_disable_write_same helper · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 05/12] sd: add a sd_disable_write_same helper · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 05/12] sd: add a sd_disable_write_same helper · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
[PATCH 06/12] sd: simplify the disable case in sd_config_discard · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 06/12] sd: simplify the disable case in sd_config_discard · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 06/12] sd: simplify the disable case in sd_config_discard · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
[PATCH 07/12] sd: factor out a sd_discard_mode helper · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 07/12] sd: factor out a sd_discard_mode helper · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 07/12] sd: factor out a sd_discard_mode helper · Bart Van Assche <bvanassche@acm.org> · 2024-05-29
[PATCH 08/12] sd: cleanup zoned queue limits initialization · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 08/12] sd: cleanup zoned queue limits initialization · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 08/12] sd: cleanup zoned queue limits initialization · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
[PATCH 09/12] sd: convert to the atomic queue limits API · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 09/12] sd: convert to the atomic queue limits API · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 09/12] sd: convert to the atomic queue limits API · John Garry <john.g.garry@oracle.com> · 2024-05-30
Re: [PATCH 09/12] sd: convert to the atomic queue limits API · Christoph Hellwig <hch@lst.de> · 2024-05-31
[PATCH 10/12] sr: convert to the atomic queue limits API · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 10/12] sr: convert to the atomic queue limits API · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
[PATCH 11/12] block: remove unused queue limits API · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 11/12] block: remove unused queue limits API · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 11/12] block: remove unused queue limits API · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
Re: [PATCH 11/12] block: remove unused queue limits API · John Garry <john.g.garry@oracle.com> · 2024-05-31
[PATCH 12/12] block: add special APIs for run-time disabling of discard and friends · Christoph Hellwig <hch@lst.de> · 2024-05-29
Re: [PATCH 12/12] block: add special APIs for run-time disabling of discard and friends · Damien Le Moal <dlemoal@kernel.org> · 2024-05-29
Re: [PATCH 12/12] block: add special APIs for run-time disabling of discard and friends · Bart Van Assche <bvanassche@acm.org> · 2024-05-30
Re: [PATCH 12/12] block: add special APIs for run-time disabling of discard and friends · John Garry <john.g.garry@oracle.com> · 2024-05-31

From: Damien Le Moal <dlemoal@kernel.org>
Date: 2024-05-29 08:10:50
Also in: ceph-devel, linux-scsi, linux-um, xen-devel

On 5/29/24 14:04, Christoph Hellwig wrote:

Add helper to disable discard when it is not supported and use it
instead of sd_config_discard in the I/O completion handler.  This avoids
touching more fields than required in the I/O completion handler and
prepares for converting sd to use the atomic queue limits API.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help