Thread (35 messages) 35 messages, 4 authors, 2023-12-13

Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

From: Christoph Hellwig <hch@infradead.org>
Date: 2023-12-12 13:15:06
Also in: gfs2, linux-bcache, linux-bcachefs, linux-btrfs, linux-ext4, linux-fsdevel, linux-s390, linux-scsi, lkml, xen-devel

On Mon, Dec 11, 2023 at 05:52:17PM +0100, Jan Kara wrote:
quoted
+void bdev_associated_mapping(struct block_device *bdev,
+			     struct address_space *mapping)
+{
+	mapping->host = bdev->bd_inode;
+}
Here I'm not sure - is the helper really a win? It seems a bit obscure to
me. This initialization of another mapping for a bdev looks really special.
If we want to hide bd_inode we'll something like this helper even if
I don't particularly like it either.

But it might be a good idea to move out of this series and into the
follow on removing bd_inode, as it's rather pointless without that
context.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help