Re: [PATCH v10 11/18] scsi: ufs: Change the return type of ufshcd_auto_hibern8_update()
From: Can Guo <hidden>
Date: 2023-08-21 05:32:16
Also in:
linux-scsi
On 8/19/2023 3:34 AM, Bart Van Assche wrote:
quoted hunk ↗ jump to hunk
A later patch will introduce an error path in ufshcd_auto_hibern8_update(). Change the return type of that function before introducing calls to that function in the host drivers such that the host drivers only have to be modified once. Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: Can Guo <redacted> Cc: Avri Altman <avri.altman@wdc.com> Cc: Bao D. Nguyen <redacted> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/ufs/core/ufs-sysfs.c | 2 +- drivers/ufs/core/ufshcd-priv.h | 1 - drivers/ufs/core/ufshcd.c | 6 ++++-- include/ufs/ufshcd.h | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-)diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-sysfs.c index 6c72075750dd..a693dea1bd18 100644 --- a/drivers/ufs/core/ufs-sysfs.c +++ b/drivers/ufs/core/ufs-sysfs.c@@ -203,7 +203,7 @@ static ssize_t auto_hibern8_store(struct device *dev, goto out; } - ufshcd_auto_hibern8_update(hba, ufshcd_us_to_ahit(timer)); + ret = ufshcd_auto_hibern8_update(hba, ufshcd_us_to_ahit(timer)); out:
Reviewed-by: Can Guo <redacted>