On 8/17/23 04:25, Damien Le Moal wrote:

quoted

  static int scsi_debug_slave_alloc(struct scsi_device *sdp)
  {
+	struct request_queue *q = sdp->request_queue;
+
  	if (sdebug_verbose)
  		pr_info("slave_alloc <%u %u %u %llu>\n",
  		       sdp->host->host_no, sdp->channel, sdp->id, sdp->lun);
+	if (sdeb_no_zwrl)
+		q->limits.driver_preserves_write_order = true;

The option is named and discribed as "no_zone_write_lock", which is a block
layer concept. Given that this sets driver_preserves_write_order and does not
touch the use_zone_write_locking limit, I think it is better to name the option
"preserve_write_order" (or similar) to avoid confusion.

I will make this change.

Thanks,

Bart.