Re: [PATCH 02/29] block: Use bdev_open_by_dev() in blkdev_open()

On Mon, Aug 28, 2023 at 06:46:13PM +0200, Jan Kara wrote:

On Fri 25-08-23 15:29:11, Christian Brauner wrote:

quoted

quoted

file->f_flags. Attached is a version of the patch that I'm currently
testing.

Appended patch looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>

The patch also has another fix for O_EXCL. In earlier versions of this
patch series it relied of f_flags. Thanks for that comment you added in
there about this now. This really helps given that O_EXCL has special
meaning for block devices. Ideally we'd have kernel doc for
file_to_blk_mode().

Thanks for review! I've added the kerneldoc comment:

/**
 * file_to_blk_mode - get block open flags from file flags
 * @file: file whose open flags should be converted
 *
 * Look at file open flags and generate corresponding block open flags from
 * them. The function works both for file just being open (e.g. during ->open
 * callback) and for file that is already open. This is actually non-trivial
 * (see comment in the function).
 */

Perfect, thanks!