Thread (26 messages) 26 messages, 5 authors, 2023-09-13

Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write

From: Christoph Hellwig <hch@lst.de>
Date: 2023-08-28 14:16:05
Also in: ceph-devel, linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-nfs, linux-xfs

On Mon, Aug 28, 2023 at 02:56:15PM +0100, Al Viro wrote:
The first failure exit does not need any work - the caller had not bumped
->ki_pos; the second one (after that 'if (err < 0) {' line) does and that's
where the patch upthread adds iocb->ki_pos -= buffered_written.

Or am I completely misparsing what you've written?
No, I misread the patch.  Looks good:

Acked-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help