Re: [PATCH 03/17] btrfs: call btrfs_close_devices from ->kill_sb
From: Christian Brauner <brauner@kernel.org>
Date: 2023-08-11 12:03:45
Also in:
linux-btrfs, linux-fsdevel, linux-s390
From: Christian Brauner <brauner@kernel.org>
Date: 2023-08-11 12:03:45
Also in:
linux-btrfs, linux-fsdevel, linux-s390
On Fri, Aug 11, 2023 at 12:08:14PM +0200, Christoph Hellwig wrote:
blkdev_put must not be called under sb->s_umount to avoid a lock order reversal with disk->open_mutex once call backs from block devices to the file system using the holder ops are supported. Move the call to btrfs_close_devices into btrfs_free_fs_info so that it is closed from ->kill_sb (which is also called from the mount failure handling path unlike ->put_super) as well as when an fs_info is freed because an existing superblock already exists. Signed-off-by: Christoph Hellwig <hch@lst.de> ---
Looks good to me, Reviewed-by: Christian Brauner <brauner@kernel.org>