Thread (7 messages) 7 messages, 2 authors, 2023-08-21

Re: [PATCH blktests v2 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2023-08-21 07:43:30
Also in: linux-nvme, lkml

quoted
quoted
diff --git a/tests/nvme/003 b/tests/nvme/003
index 71b82ce758a3..eed1f549866a 100755
--- a/tests/nvme/003
+++ b/tests/nvme/003
@@ -22,15 +22,8 @@ test() {
   	_setup_nvmet
-	local loop_dev
-	local port
-	port="$(_create_nvmet_port "${nvme_trtype}")"
-
-	loop_dev="$(losetup -f)"
-
-	_create_nvmet_subsystem "${def_subsysnqn}" "${loop_dev}"
-	_add_nvmet_subsys_to_port "${port}" "${def_subsysnqn}"
+	_nvmet_target_setup --blkdev=device
--blkdev=device by default no?
Yes. I thought it is better to be explicit in the tests. I don't mind
dropping --blkdev=device if you think we should use the defaults.
Just wondering why it is different than all the rest of the defaults?
It probably can be omitted from the callers.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help