Re: [PATCH blktests v1 1/3] nvme/048: Check for queue count check directly

On Tue, Jun 27, 2023 at 10:13:48AM +0000, Shinichiro Kawasaki wrote:

quoted

+	nvmf_wait_for_state "${subsys_name}" "live" || return 1
+
+	queue_count=$((queue_count + 1))
+	if grep -q "${queue_count}" "${queue_count_file}"; then

Does this check work when the number in queue_count_file has more digits than
queue_count? e.g.) queue_count_file=20, queue_count=2

The idea is that it should be an exact match. Let me figure out if this does
what it is supposed to do.

 > -	hostnqn="nqn.2014-08.org.nvmexpress:uuid:${hostid}"

quoted

+	hostid="${def_hostid}"
+	hostnqn="${def_hostnqn}"

I guess it's the better to move this hunk to the 3rd patch. Or we can mention it
in the commit message of this patch.

Good point, I'll move this to the 3rd patch so this change is in one patch.