Re: [PATCH 08/24] init: pass root_device_name explicitly

From
Max Filippov <jcmvbkbc@gmail.com>
Date
2023-06-27 10:39:09
Also in
dm-devel, linux-pm, lkml
Reply to
Guenter Roeck, 2023-06-26
On Mon, Jun 26, 2023 at 8:10 AM Guenter Roeck [off-list ref] wrote:
On 6/26/23 00:53, Christoph Hellwig wrote:
quoted
On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote:
quoted
Hi,

On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote:
quoted
Instead of declaring root_device_name as a global variable pass it as an
argument to the functions using it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
This patch results in the following build error when trying to build
xtensa:tinyconfig.

WARNING: modpost: vmlinux: section mismatch in reference: strcpy.isra.0+0x14 (section: .text.unlikely) -> initcall_level_names (section: .init.data)
ERROR: modpost: Section mismatches detected.
I can reproduce these with gcc 13.1 on xtensa, but the report makes
no sense to me.  If I disable CONFIG_CC_OPTIMIZE_FOR_SIZE it now reports
a similar warning for put_page intead of strcpy which seems just as
arcance.
I don't see that (I tried 11.3, 11.4, 12.3, and 13.1), but then I am not sure
if this is worth tracking down. I just force CONFIG_SECTION_MISMATCH_WARN_ONLY=y
for xtensa builds instead.
I believe it's yet another manifestation of the following issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938

Hunting is still on my todo list, but it's quite low, so I guess
forcing CONFIG_SECTION_MISMATCH_WARN_ONLY=y for xtensa
is the right thing to do for now.

-- 
Thanks.
-- Max
Thread (34 messages) 34 messages, 7 authors, last reply 2023-08-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help