Thread (35 messages) 35 messages, 5 authors, 2023-02-15

Re: [PATCH v14 01/12] splice: Fix O_DIRECT file read splice to avoid reversion of ITER_PIPE

From: Christoph Hellwig <hch@infradead.org>
Date: 2023-02-13 08:22:54
Also in: linux-fsdevel, linux-mm, lkml

+	if (!bv)
+		return -ENOMEM;
+
+	pages = (void *)(bv + npages);
I think this cast should be to struct page **… not void *.
+	npages = alloc_pages_bulk_array(GFP_USER, npages, pages);
+	if (!npages) {
+		kfree(bv);
+		return -ENOMEM;
+	}
+	reclaim = npages * PAGE_SIZE;
+	remain = 0;
+	if (ret > 0) {
+		reclaim -= ret;
+		remain = ret;
...
+	/* Free any pages that didn't get touched at all. */
+	reclaim /= PAGE_SIZE;
Any reason not to keep reclaim in PAGE_SIZE units to start with?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help