Thread (19 messages) 19 messages, 4 authors, 2023-02-09

Re: [PATCH v12 01/10] vfs, iomap: Fix generic_file_splice_read() to avoid reversion of ITER_PIPE

From: Matthew Wilcox <willy@infradead.org>
Date: 2023-02-08 17:22:08
Also in: linux-fsdevel, linux-mm, lkml

On Wed, Feb 08, 2023 at 04:09:51PM +0000, David Howells wrote:
quoted hunk ↗ jump to hunk
@@ -2688,7 +2689,7 @@ ssize_t filemap_read(struct kiocb *iocb, struct iov_iter *iter,
 		if (unlikely(iocb->ki_pos >= i_size_read(inode)))
 			break;
 
-		error = filemap_get_pages(iocb, iter, &fbatch);
+		error = filemap_get_pages(iocb, iov_iter_count(iter), &fbatch);
What's the point in iov_iter_count() anyway?  It's more characters
than iter->count, so why not use it directly?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help