[PATCH v4 01/14] blk-mq: avoid sleep in blk_mq_alloc_request_hctx · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
[PATCH v4 03/14] blk-mq: wait on correct sbitmap_queue in blk_mq_mark_tag_wait · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
[PATCH v4 02/14] blk-mq: remove stale comment for blk_mq_sched_mark_restart_hctx · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
[PATCH v4 04/14] blk-mq: Fix potential io hung for shared sbitmap per tagset · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 04/14] blk-mq: Fix potential io hung for shared sbitmap per tagset · Christoph Hellwig <hch@lst.de> · 2023-02-06
[PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits · Christoph Hellwig <hch@lst.de> · 2023-01-18
Re: [PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-19
Re: [PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-28
Re: [PATCH v4 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits · Christoph Hellwig <hch@lst.de> · 2023-02-06
[PATCH v4 06/14] blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 06/14] blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct · Christoph Hellwig <hch@lst.de> · 2023-01-18
Re: [PATCH v4 06/14] blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct · Christoph Hellwig <hch@lst.de> · 2023-02-06
[PATCH v4 10/14] blk-mq: simplify flush check in blk_mq_dispatch_rq_list · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 10/14] blk-mq: simplify flush check in blk_mq_dispatch_rq_list · Christoph Hellwig <hch@lst.de> · 2023-01-18
Re: [PATCH v4 10/14] blk-mq: simplify flush check in blk_mq_dispatch_rq_list · Christoph Hellwig <hch@lst.de> · 2023-02-06
[PATCH v4 05/14] blk-mq: remove unnecessary list_empty check in blk_mq_try_issue_list_directly · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
[PATCH v4 09/14] blk-mq: use blk_mq_commit_rqs helper in blk_mq_try_issue_list_directly · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 09/14] blk-mq: use blk_mq_commit_rqs helper in blk_mq_try_issue_list_directly · Christoph Hellwig <hch@lst.de> · 2023-01-18
Re: [PATCH v4 09/14] blk-mq: use blk_mq_commit_rqs helper in blk_mq_try_issue_list_directly · Christoph Hellwig <hch@lst.de> · 2023-02-06
[PATCH v4 13/14] blk-mq: use switch/case to improve readability in blk_mq_try_issue_list_directly · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 13/14] blk-mq: use switch/case to improve readability in blk_mq_try_issue_list_directly · Christoph Hellwig <hch@lst.de> · 2023-01-18
[PATCH v4 14/14] blk-mq: correct stale comment of .get_budget · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 14/14] blk-mq: correct stale comment of .get_budget · Christoph Hellwig <hch@lst.de> · 2023-01-18
[PATCH v4 12/14] blk-mq: remove set of bd->last when get driver tag for next request fails · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 12/14] blk-mq: remove set of bd->last when get driver tag for next request fails · Christoph Hellwig <hch@lst.de> · 2023-01-18
Re: [PATCH v4 12/14] blk-mq: remove set of bd->last when get driver tag for next request fails · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-19
Re: [PATCH v4 12/14] blk-mq: remove set of bd->last when get driver tag for next request fails · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-28
Re: [PATCH v4 12/14] blk-mq: remove set of bd->last when get driver tag for next request fails · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-02-06
Re: [PATCH v4 12/14] blk-mq: remove set of bd->last when get driver tag for next request fails · Christoph Hellwig <hch@lst.de> · 2023-02-06
[PATCH v4 11/14] blk-mq: remove unnecessary error count and check in blk_mq_dispatch_rq_list · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 11/14] blk-mq: remove unnecessary error count and check in blk_mq_dispatch_rq_list · Christoph Hellwig <hch@lst.de> · 2023-01-18
Re: [PATCH v4 11/14] blk-mq: remove unnecessary error count and check in blk_mq_dispatch_rq_list · Christoph Hellwig <hch@lst.de> · 2023-02-06
[PATCH v4 08/14] blk-mq: remove unncessary error count and commit in blk_mq_plug_issue_direct · Kemeng Shi <shikemeng@huaweicloud.com> · 2023-01-18
Re: [PATCH v4 08/14] blk-mq: remove unncessary error count and commit in blk_mq_plug_issue_direct · Christoph Hellwig <hch@lst.de> · 2023-01-18
Re: [PATCH v4 08/14] blk-mq: remove unncessary error count and commit in blk_mq_plug_issue_direct · Christoph Hellwig <hch@lst.de> · 2023-02-06
Re: [PATCH v4 01/14] blk-mq: avoid sleep in blk_mq_alloc_request_hctx · Jens Axboe <axboe@kernel.dk> · 2023-02-06

Re: [PATCH v4 06/14] blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct

From: Christoph Hellwig <hch@lst.de>
Date: 2023-01-18 17:36:33
Also in: lkml

On Wed, Jan 18, 2023 at 05:37:18PM +0800, Kemeng Shi wrote:

Function blk_mq_plug_issue_direct tries to issue batch requests in plug
list to driver directly. We will only issue plug request to driver if we
are not from scheduler, so from_scheduler parameter of
blk_mq_plug_issue_direct is always false.
Remove unncessary from_scheduler of blk_mq_plug_issue_direct.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help