Thread (8 messages) 8 messages, 2 authors, 2022-10-17
STALE1349d
Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH 2/3] block: Correct comment for scale_cookie_change

From: Kemeng Shi <hidden>
Date: 2022-09-29 07:41:42
Also in: cgroups, lkml
Subsystem: block layer, control group - block io controller (blkio), the rest · Maintainers: Jens Axboe, Tejun Heo, Josef Bacik, Linus Torvalds

Default queue depth of iolatency_grp is unlimited, so we scale down
quickly(once by half) in scale_cookie_change. Remove the "subtract
1/16th" part which is not the truth.

Signed-off-by: Kemeng Shi <redacted>
---
 block/blk-iolatency.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
index a8cc5abe91e5..2666afd7abdb 100644
--- a/block/blk-iolatency.c
+++ b/block/blk-iolatency.c
@@ -364,7 +364,7 @@ static void scale_cookie_change(struct blk_iolatency *blkiolat,
 }
 
 /*
- * Change the queue depth of the iolatency_grp.  We add/subtract 1/16th of the
+ * Change the queue depth of the iolatency_grp.  We add 1/16th of the
  * queue depth at a time so we don't get wild swings and hopefully dial in to
  * fairer distribution of the overall queue depth.
  */
-- 
2.30.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help