Re: [PATCH blktests] nvme/043,044,045: load dh_generic module
From: Chaitanya Kulkarni <hidden>
Date: 2022-08-31 10:45:47
Also in:
linux-nvme
On 8/30/22 22:27, Shin'ichiro Kawasaki wrote:
quoted hunk ↗ jump to hunk
Test cases nvme/043, 044 and 045 use DH group which relies on dh_generic module. When the module is built as a loadable module, the test cases fail since the module is not loaded at test case runs. To avoid the failures, load the dh_generic module at the preparation step of the test cases. Also unload it at test end for clean up. Reported-by: Sagi Grimberg <sagi@grimberg.me> Fixes: 38d7c5e8400f ("nvme/043: test hash and dh group variations for authenticated connections") Fixes: 63bdf9c16b19 ("nvme/044: test bi-directional authentication") Fixes: 7640176ef7cc ("nvme/045: test re-authentication") Signed-off-by: Shin'ichiro Kawasaki <redacted> Link: https://lore.kernel.org/linux-block/a5c3c8e7-4b0a-9930-8f90-e534d2a82bdf@grimberg.me/ (local) --- tests/nvme/043 | 4 ++++ tests/nvme/044 | 4 ++++ tests/nvme/045 | 4 ++++ 3 files changed, 12 insertions(+)diff --git a/tests/nvme/043 b/tests/nvme/043 index 381ae75..dbe9d3f 100755 --- a/tests/nvme/043 +++ b/tests/nvme/043@@ -40,6 +40,8 @@ test() { _setup_nvmet + modprobe -q dh_generic + truncate -s 512M "${file_path}" _create_nvmet_subsystem "${subsys_name}" "${file_path}"
it actually makes sense to move above calls into common helper called nvme_auth_test_setup() and similar code for the teardown nvme_auth_teardown() for nvme-auth testcases instead of duplicating the code. -ck