Re: [PATCH] rnbd-srv: remove 'dir' argument from rnbd_srv_rdma_ev
From: Jinpu Wang <jinpu.wang@ionos.com>
Date: 2022-08-29 12:33:53
Also in:
linux-rdma
From: Jinpu Wang <jinpu.wang@ionos.com>
Date: 2022-08-29 12:33:53
Also in:
linux-rdma
On Fri, Aug 26, 2022 at 4:02 PM Guoqing Jiang [off-list ref] wrote:
On 8/26/22 7:58 PM, Jinpu Wang wrote:quoted
quoted
And I guess we can just pass parameters with register after remove an argument, otherwise need to push/pop stack with more than six parameters for x64.I doubt it makes any notable performance change.I think it is called in the IO path (process_read and process_write) ... BTW, do you agree if the 'usr' can be dropped from rdma_ev given it is always same as 'data + data_len'?
in the current form, yes, usr can be dropped. we can add later if there is a need.
Thanks, Guoqing
Thx!