Thread (4 messages) 4 messages, 3 authors, 2022-08-26

Re: [PATCH v2] block: I/O error occurs during SATA disk stress test

From: Bart Van Assche <bvanassche@acm.org>
Date: 2022-08-26 16:06:53

On 8/26/22 06:36, Jens Axboe wrote:
That aside, I think there's a misunderstanding here. v1 has some
parts and v2 has others. Please post a v3 that has the hunk
that guarantees that deadline always has the lowest bit set if
assigned, and the !deadline check as well.
Hi Jens,

Would it be considered acceptable to store the request state (rq->state) 
in the lowest two bits of rq->deadline? This would reduce the deadline 
resolution a little bit but I think that's acceptable. Except for 
blk_abort_request(), all changes of rq->state and rq->deadline are 
already serialized. So with this approach only blk_abort_request() would 
have to use an atomic-compare-exchange loop.

Thanks,

Bart.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help