Thread (31 messages) 31 messages, 5 authors, 2022-09-01

Re: [PATCH 2/6] block: add dio_w_*() wrappers for pin, unpin user pages

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2022-08-28 00:12:26
Also in: linux-fsdevel, linux-mm, linux-nfs, linux-xfs, lkml

On Sat, 27 Aug 2022 16:59:32 -0700 John Hubbard [off-list ref] wrote:
Anyway, I'll change my patch locally for now, to this:

static inline void dio_w_unpin_user_pages(struct page **pages,
					  unsigned long npages)
{
	/* Careful, release_pages() uses a smaller integer type for npages: */
	if (WARN_ON_ONCE(npages > (unsigned long)INT_MAX))
		return;

	release_pages(pages, (int)npages);
}
Well, it might be slower.  release_pages() has a ton of fluff.

As mentioned, the above might be faster if the pages tend
to have page_count()==1??
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help