On 8/30/22 6:42 PM, Liu Song wrote:

On 2022/8/30 21:59, Jens Axboe wrote:

quoted

On 8/30/22 3:45 AM, Liu Song wrote:

quoted

From: Liu Song <redacted>

Change "bio_set_ioprio" to inline to avoid calling overhead.

Let's not try to 2nd guess the compiler here. Most things that are
marked inline should not be.

Agree, I think there is something wrong with the commit log written here,
it should be expected to reduce the call overhead, bio_set_ioprio seems
to be appropriate to use inline.

I'm sure it's worth inlining, but did you check if it isn't already?
If it's small I'd fully expect the compiler to inline it already,
without needing to add things to do so.

-- 
Jens Axboe