Re: [PATCH 3/4] blk-throttle: cleanup tg_update_disptime()
From: Tejun Heo <tj@kernel.org>
Date: 2022-08-23 19:35:44
Also in:
cgroups, lkml
From: Tejun Heo <tj@kernel.org>
Date: 2022-08-23 19:35:44
Also in:
cgroups, lkml
On Tue, Aug 23, 2022 at 09:38:09AM +0800, Yu Kuai wrote:
From: Yu Kuai <redacted> tg_update_disptime() only need to adjust postion for 'tg' in 'parent_sq', there is no need to call throtl_enqueue/dequeue_tg(), since they will set/clear flag THROTL_TG_PENDING and increase/decrease nr_pending, which is useless. By the way, clear the flag/decrease nr_pending while there are still throttled bios is not good for debugging. There are no functional changes. Signed-off-by: Yu Kuai <redacted>
Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun