On 6/15/22 3:01 PM, Bart Van Assche wrote:

Since the introduction of blk_mq_get_hctx_type() the operation type in
the second argument of blk_mq_get_hctx_type() matters. Make sure that
blk_mq_get_sq_hctx() selects a hardware queue of type HCTX_TYPE_DEFAULT
instead of a hardware queue of type HCTX_TYPE_READ.

You ignored my comment here. A good changelog explains WHY a change is
made, not what the change does. For that, I can just read the change.

So please change the commit message to say WHY it's important. Or if
it's not, make it clear that it is a cosmetic thing.

-- 
Jens Axboe