On Mon, May 23, 2022 at 02:01:17PM -0700, Keith Busch wrote:

+	const unsigned max_bytes = get_max_io_size(q, bio) << 9;

+	return bio_split(bio, bytes >> 9, GFP_NOIO, bs);

These should use SECTOR_SHIFT.

 split:
 	*segs = nsegs;
+	bytes = ALIGN_DOWN(bytes, queue_logical_block_size(q));

Please add a comment explaining the added alignment here.