On Thu, May 19, 2022 at 10:27:04AM -0700, Eric Biggers wrote:

On Thu, May 19, 2022 at 11:01:05AM -0600, Keith Busch wrote:

quoted

On Wed, May 18, 2022 at 10:56:04PM -0600, Keith Busch wrote:

quoted

On Wed, May 18, 2022 at 08:27:31PM -0700, Eric Biggers wrote:

quoted

Note, there's also lots of code that assumes that bio_vec::bv_len is a multiple
of 512.  

Could you point me to some examples?

Just to answer my own question, blk-crypto and blk-merge appear to have these
512 byte bv_len assumptions.

blk_bio_segment_split() and bio_advance_iter() are two more examples.

I agree about blk_bio_segment_split(), but bio_advance_iter() looks fine. That
just assumes the entire length is a multiple of 512, not any particular bvec.

Anyway, I accept your point that some existing code has this assumption, and
will address these before the next revision.