Thread (18 messages) 18 messages, 2 authors, 2022-05-19
STALE1506d
Revisions (3)
  1. v1 current
  2. v2 [diff vs current]
  3. v3 [diff vs current]

[PATCH -next 6/8] block, bfq: remove dead code for updating 'rq_in_driver'

From: Yu Kuai <hidden>
Date: 2022-05-14 08:51:54
Also in: cgroups, lkml
Subsystem: bfq i/o scheduler, block layer, the rest · Maintainers: Yu Kuai, Jens Axboe, Linus Torvalds

Such code are not even compiled since they are inside marco "#if 0".

Signed-off-by: Yu Kuai <redacted>
---
 block/bfq-iosched.c | 16 ----------------
 1 file changed, 16 deletions(-)
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 1d0141c450c0..e36a16684fb4 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -2322,22 +2322,6 @@ static sector_t get_sdist(sector_t last_pos, struct request *rq)
 	return 0;
 }
 
-#if 0 /* Still not clear if we can do without next two functions */
-static void bfq_activate_request(struct request_queue *q, struct request *rq)
-{
-	struct bfq_data *bfqd = q->elevator->elevator_data;
-
-	bfqd->rq_in_driver++;
-}
-
-static void bfq_deactivate_request(struct request_queue *q, struct request *rq)
-{
-	struct bfq_data *bfqd = q->elevator->elevator_data;
-
-	bfqd->rq_in_driver--;
-}
-#endif
-
 static void bfq_remove_request(struct request_queue *q,
 			       struct request *rq)
 {
-- 
2.31.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help