On 02/03/2022 01:47, Ming Lei wrote:

quoted

quoted

   static struct blk_mq_tags *blk_mq_alloc_rq_map(struct blk_mq_tag_set *set,
   					       unsigned int hctx_idx,
   					       unsigned int nr_tags,
   					       unsigned int reserved_tags)
   {
   	struct blk_mq_tags *tags;
-	int node;
+	int node = blk_mq_get_hctx_node(set, hctx_idx);

nit: the code originally had reverse firtree ordering, which I suppose is
not by mistake

What is reverse firtree ordering here? I don't know what is wrong
with the above one line change from patch style viewpoint, and
checkpatch complains nothing here.

checkpath would not complain about this. I'm talking about:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst#n587

The original code had:

	struct blk_mq_tags *tags;
	int node;

as opposed to:

	int node;
	struct blk_mq_tags *tags;

That's all. The block code seems to mostly follow this style when 
possible. It's just a style issue.

thanks,
John