Re: [PATCH] block-map: add __GFP_ZERO flag for alloc_page in function bio_copy_kern
From: Chaitanya Kulkarni <hidden>
Date: 2022-02-16 17:12:22
From: Chaitanya Kulkarni <hidden>
Date: 2022-02-16 17:12:22
On 2/16/22 09:05, Christoph Hellwig wrote:
On Wed, Feb 16, 2022 at 09:12:21AM +0000, Chaitanya Kulkarni wrote:quoted
but blk_rq_map_kern() does accept gfp_mask for exactly this same case and that is passed on to the bio_copy_kern() unless I'm wrong here, so you need to pass the __GFP_ZERO flag in the step 3 above (sg_scsi_ioctl) and not force zzeroed allocation the generic API..We only want the zeroing for the payload, and other callers have the same issue, so I think this patch is the right thing to do.
okay, in that case looks good... Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>