Re: [PATCH V2 4/4] loop: allow user to set the queue depth

[PATCH V2 0/4] loop: cleanup and few improvements · Chaitanya Kulkarni <kch@nvidia.com> · 2022-02-15
[PATCH V2 1/4] loop: use sysfs_emit() in the sysfs xxx show() · Chaitanya Kulkarni <kch@nvidia.com> · 2022-02-15
[PATCH V2 2/4] loop: remove extra variable in lo_fallocate() · Chaitanya Kulkarni <kch@nvidia.com> · 2022-02-15
[PATCH V2 4/4] loop: allow user to set the queue depth · Chaitanya Kulkarni <kch@nvidia.com> · 2022-02-15
Re: [PATCH V2 4/4] loop: allow user to set the queue depth · Jens Axboe <axboe@kernel.dk> · 2022-02-15
Re: [PATCH V2 4/4] loop: allow user to set the queue depth · Chaitanya Kulkarni <hidden> · 2022-02-15
[PATCH V2 3/4] loop: remove extra variable in lo_req_flush · Chaitanya Kulkarni <kch@nvidia.com> · 2022-02-15

From: Jens Axboe <axboe@kernel.dk>
Date: 2022-02-15 14:54:20

On 2/15/22 4:51 AM, Chaitanya Kulkarni wrote:

Instead of hardcoding queue depth allow user to set the hw queue depth
using module parameter. Set default value to 128 to retain the existing
behavior.

Do we want to ensure that the depth falls within a reasonable range? I
guess we don't if we just ensure that it fails gracefully. Eg have you
tried the usual sanity checks of -1, 0, 1, huge?

-- 
Jens Axboe

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help