Re: [PATCH 3/6] block, fs: assert that key paths use iovecs, and nothing else

On 2/27/22 13:58, Jens Axboe wrote:

quoted

diff --git a/block/bio.c b/block/bio.c
index b15f5466ce08..4679d6539e2d 100644
--- a/block/bio.c
+++ b/block/bio.c

@@ -1167,6 +1167,8 @@ static int __bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)
  	BUILD_BUG_ON(PAGE_PTRS_PER_BVEC < 2);
  	pages += entries_left * (PAGE_PTRS_PER_BVEC - 1);
  
+	WARN_ON_ONCE(!iter_is_iovec(iter));
+

If these make sense, why aren't they also returning an error?

Oops. Got caught up in the luxury of local testing and watching the
logs, but also returning errors is of course the right answer. Will fix.

thanks,
-- 
John Hubbard
NVIDIA